fecConfig: Fix a few issues in the config (HMS-11177) - #4725
Open
regexowl wants to merge 5 commits into
Open
Conversation
The path was malformed, so this had no effect. The check is a bit defensive, but no harm in keeping it as a safeguard.
`/beta` url was deprecated with the platform switching to preview. This was just never cleaned up.
This is just stylistic change, feels cleaner this way.
This removes the add_define plugin that was originally used for msw in browser. Since msw was deprecated and the helper was always hitting the `else` branch, we can just inline it now.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #4725 +/- ##
=======================================
Coverage 77.87% 77.87%
=======================================
Files 263 263
Lines 7037 7037
Branches 2588 2552 -36
=======================================
Hits 5480 5480
+ Misses 1462 1459 -3
- Partials 95 98 +3
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Collaborator
Author
|
/jira-epic HMS-10979 |
schutzbot
changed the title
regexowl
marked this pull request as ready for review
August 7, 2026 12:23
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This:
add_definehelperJIRA: HMS-11177